DIvan2000/ReplayModCinematic
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Reduce object creation during rendering of path preview

Browse Source 
Skip sqrt when comparing distances
This commit is contained in:
johni0702
2015-06-29 18:12:38 +02:00
parent 540588125b
commit 3122c0a71e
2 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/main/java/eu/crushedpixel/replaymod/holders/Position.java
View File

@@ -82,12 +82,11 @@ public class Position {
public void setRoll(float roll) { this.roll = roll; }
public double distanceTo(double x, double y, double z) {
return distanceTo(new Position(x, y, z, 0, 0));
}
public double distanceTo(Position p2) {
return Math.sqrt(Math.pow((p2.getX() - getX()), 2) + Math.pow((p2.getY() - getY()), 2) + Math.pow((p2.getZ() - getZ()), 2));
public double distanceSquared(double x, double y, double z) {
double dx = this.x - x;
double dy = this.y - y;
double dz = this.z - z;
return dx * dx + dy * dy + dz * dz;
}
@Override

2
src/main/java/eu/crushedpixel/replaymod/renderer/PathPreviewRenderer.java
View File

@@ -130,7 +130,7 @@ public class PathPreviewRenderer {
@Override
public int compare(PositionKeyframe o1, PositionKeyframe o2) {
return -(new Double(o1.getPosition().distanceTo(playerX, playerY, playerZ)).compareTo(o2.getPosition().distanceTo(playerX, playerY, playerZ)));
return -(new Double(o1.getPosition().distanceSquared(playerX, playerY, playerZ)).compareTo(o2.getPosition().distanceSquared(playerX, playerY, playerZ)));
}
@Override