DIvan2000/ReplayModCinematic
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #366 from altrisi/patch-1

Browse Source 
Don't create an empty directory with no modcore available
This commit is contained in:
Jonas Herzig
2020-09-20 08:00:56 +02:00
committed by GitHub
parent 3db25abe48 0561a9f53c
commit cff6034079
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/main/java/com/replaymod/extras/modcore/ModCoreInstaller.java
View File

@@ -122,6 +122,11 @@ public class ModCoreInstaller {
public static int initialize(File gameDir, String minecraftVersion) { public static int initialize(File gameDir, String minecraftVersion) {
if (isInitalized()) return -1; if (isInitalized()) return -1;
JsonHolder jsonHolder = fetchJSON(VERSION_URL);
if (!jsonHolder.has(minecraftVersion)) {
System.out.println("No ModCore target for " + minecraftVersion + ". This in fine, unless you're specifically looking for ModCore.");
return -2;
}
dataDir = new File(gameDir, "modcore"); dataDir = new File(gameDir, "modcore");
if (!dataDir.exists()) { if (!dataDir.exists()) {
if (!dataDir.mkdirs()) { if (!dataDir.mkdirs()) {
@@ -129,11 +134,6 @@ public class ModCoreInstaller {
return 1; return 1;
} }
} }
JsonHolder jsonHolder = fetchJSON(VERSION_URL);
if (!jsonHolder.has(minecraftVersion)) {
System.out.println("No ModCore target for " + minecraftVersion + ". This in fine, unless you're specifically looking for ModCore.");
return -2;
}
String latestRemote = jsonHolder.optString(minecraftVersion); String latestRemote = jsonHolder.optString(minecraftVersion);
boolean failed = jsonHolder.getKeys().size() == 0 || (jsonHolder.has("success") && !jsonHolder.optBoolean("success")); boolean failed = jsonHolder.getKeys().size() == 0 || (jsonHolder.has("success") && !jsonHolder.optBoolean("success"));