Fix render settings not saving when rendering (fixes #425)
Clicking Cancel or Add to Queue does save them but clicking Render does not. This is caused by the fact that the GuiRenderSettings are now a popup and no longer their own screen, so to close them, we need to call its close method, not close the entire screen.
This commit is contained in:
@@ -50,7 +50,7 @@ public class GuiCreateScreenshot extends GuiRenderSettings implements Loadable {
|
|||||||
buttonPanel.removeElement(queueButton);
|
buttonPanel.removeElement(queueButton);
|
||||||
renderButton.setI18nLabel("replaymod.gui.advancedscreenshots.create").onClick(() -> {
|
renderButton.setI18nLabel("replaymod.gui.advancedscreenshots.create").onClick(() -> {
|
||||||
// Closing this GUI ensures that settings are saved
|
// Closing this GUI ensures that settings are saved
|
||||||
getMinecraft().openScreen(null);
|
close();
|
||||||
|
|
||||||
mod.runLater(() -> {
|
mod.runLater(() -> {
|
||||||
try {
|
try {
|
||||||
|
|||||||
@@ -252,7 +252,7 @@ public class GuiRenderSettings extends AbstractGuiPopup<GuiRenderSettings> {
|
|||||||
@Override
|
@Override
|
||||||
public void run() {
|
public void run() {
|
||||||
// Closing this GUI ensures that settings are saved
|
// Closing this GUI ensures that settings are saved
|
||||||
getMinecraft().openScreen(null);
|
close();
|
||||||
try {
|
try {
|
||||||
VideoRenderer videoRenderer = new VideoRenderer(save(false), replayHandler, timeline);
|
VideoRenderer videoRenderer = new VideoRenderer(save(false), replayHandler, timeline);
|
||||||
videoRenderer.renderVideo();
|
videoRenderer.renderVideo();
|
||||||
|
|||||||
Reference in New Issue
Block a user