From c94f5d17f4f080a4576d1fc07b45fa5e1635ba37 Mon Sep 17 00:00:00 2001 From: Jonas Herzig Date: Mon, 17 Dec 2018 14:42:03 +0100 Subject: [PATCH] Fix packet data being trashed by Restore Replay GUI (fixes #129) --- src/main/java/com/replaymod/core/gui/RestoreReplayGui.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/main/java/com/replaymod/core/gui/RestoreReplayGui.java b/src/main/java/com/replaymod/core/gui/RestoreReplayGui.java index d922c1e4..62833344 100644 --- a/src/main/java/com/replaymod/core/gui/RestoreReplayGui.java +++ b/src/main/java/com/replaymod/core/gui/RestoreReplayGui.java @@ -43,6 +43,9 @@ public class RestoreReplayGui extends AbstractGuiScreen { yesButton.onClick(() -> { try { ReplayFile replayFile = new ZipReplayFile(new ReplayStudio(), null, file); + // Commit all not-yet-committed files into the main zip file. + // If we don't do this, then re-writing packet data below can actually overwrite uncommitted packet data! + replayFile.save(); ReplayMetaData metaData = replayFile.getMetaData(); if (metaData != null && metaData.getDuration() == 0) { // Try to restore replay duration