From 7790aee3cbdf0340f2b06681f51ae0da62d26016 Mon Sep 17 00:00:00 2001 From: CrushedPixel Date: Wed, 15 Jul 2015 23:59:23 +0200 Subject: [PATCH] Replaced lossless encoding with high quality ( -qp 1 instead of -qp 0 ) because (quote ffmpeg.org): Most non-FFmpeg based players will not be able to decode lossless (but YouTube can), so if compatibility is an issue you should not use lossless. --- .../replaymod/gui/GuiRenderSettings.java | 2 +- .../replaymod/settings/EncodingPreset.java | 12 ++++++------ src/main/resources/assets/replaymod/lang/en_US.lang | 6 +++--- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/main/java/eu/crushedpixel/replaymod/gui/GuiRenderSettings.java b/src/main/java/eu/crushedpixel/replaymod/gui/GuiRenderSettings.java index 0f0fa38c..143ffba5 100644 --- a/src/main/java/eu/crushedpixel/replaymod/gui/GuiRenderSettings.java +++ b/src/main/java/eu/crushedpixel/replaymod/gui/GuiRenderSettings.java @@ -176,7 +176,7 @@ public class GuiRenderSettings extends GuiScreen { ignoreCamDir = new GuiCheckBox(GuiConstants.RENDER_SETTINGS_STATIC_CAMERA, 0, 0, I18n.format("replaymod.gui.rendersettings.stablecamera"), false); ignoreCamDir.enabled = false; - encodingPresetDropdown.setSelectionIndex(0); + encodingPresetDropdown.setSelectionIndex(2); permanentButtons.add(advancedButton); permanentButtons.add(renderButton); diff --git a/src/main/java/eu/crushedpixel/replaymod/settings/EncodingPreset.java b/src/main/java/eu/crushedpixel/replaymod/settings/EncodingPreset.java index 1ba24699..73d206f7 100644 --- a/src/main/java/eu/crushedpixel/replaymod/settings/EncodingPreset.java +++ b/src/main/java/eu/crushedpixel/replaymod/settings/EncodingPreset.java @@ -8,18 +8,18 @@ import net.minecraft.client.resources.I18n; @AllArgsConstructor public enum EncodingPreset implements GuiEntryListEntry { - MP4DEFAULT("replaymod.gui.rendersettings.presets.mp4.default", - "-f rawvideo -pix_fmt argb -s %WIDTH%x%HEIGHT% -r %FPS% -i - -an -c:v libx264 -preset ultrafast -pix_fmt yuv420p %FILENAME%.mp4", "mp4"), - MP4CUSTOM("replaymod.gui.rendersettings.presets.mp4.custom", "-f rawvideo -pix_fmt argb -s %WIDTH%x%HEIGHT% -r %FPS% -i - -an -c:v libx264 -b:v %BITRATE% -pix_fmt yuv420p %FILENAME%.mp4", "mp4"), + MP4HIGH("replaymod.gui.rendersettings.presets.mp4.high", + "-f rawvideo -pix_fmt argb -s %WIDTH%x%HEIGHT% -r %FPS% -i - -an -c:v libx264 -preset ultrafast -qp 1 -pix_fmt yuv420p %FILENAME%.mp4", "mp4"), + + MP4DEFAULT("replaymod.gui.rendersettings.presets.mp4.default", + "-f rawvideo -pix_fmt argb -s %WIDTH%x%HEIGHT% -r %FPS% -i - -an -c:v libx264 -preset ultrafast -pix_fmt yuv420p %FILENAME%.mp4", "mp4"), + MP4POTATO("replaymod.gui.rendersettings.presets.mp4.potato", "-f rawvideo -pix_fmt argb -s %WIDTH%x%HEIGHT% -r %FPS% -i - -an -c:v libx264 -preset ultrafast -crf 51 -pix_fmt yuv420p %FILENAME%.mp4", "mp4"), - MKVLOSSLESS("replaymod.gui.rendersettings.presets.mkv.lossless", - "-f rawvideo -pix_fmt argb -s %WIDTH%x%HEIGHT% -r %FPS% -i - -an -c:v libx264 -preset ultrafast -qp 0 %FILENAME%.mkv", "mkv"), - WEBMCUSTOM("replaymod.gui.rendersettings.presets.webm.custom", "-f rawvideo -pix_fmt argb -s %WIDTH%x%HEIGHT% -r %FPS% -i - -an -c:v libvpx -b:v %BITRATE% %FILENAME%.webm", "webm"); diff --git a/src/main/resources/assets/replaymod/lang/en_US.lang b/src/main/resources/assets/replaymod/lang/en_US.lang index 53c8b3b9..3c22442a 100644 --- a/src/main/resources/assets/replaymod/lang/en_US.lang +++ b/src/main/resources/assets/replaymod/lang/en_US.lang @@ -329,10 +329,10 @@ replaymod.gui.rendersettings.basic=Basic Settings replaymod.gui.rendersettings.advanced=Advanced Settings replaymod.gui.rendersettings.presets=Encoding Presets -replaymod.gui.rendersettings.presets.mp4.default=MP4 - Default replaymod.gui.rendersettings.presets.mp4.custom=MP4 - Custom Bitrate -replaymod.gui.rendersettings.presets.mp4.potato=MP4 - Potato -replaymod.gui.rendersettings.presets.mkv.lossless=MKV - Lossless +replaymod.gui.rendersettings.presets.mp4.high=MP4 - High Quality +replaymod.gui.rendersettings.presets.mp4.default=MP4 - Default Quality +replaymod.gui.rendersettings.presets.mp4.potato=MP4 - Potato Quality replaymod.gui.rendersettings.presets.webm.custom=WEBM - Custom Bitrate #Rendering GUI