From 154952a8ac772fdf9ba236c422d36a1dc4de4341 Mon Sep 17 00:00:00 2001 From: Jonas Herzig Date: Sat, 23 May 2020 13:34:27 +0200 Subject: [PATCH] Change ModCore messages cause people keep thinking those are errors --- src/main/java/com/replaymod/core/ReplayModMMLauncher.java | 4 +++- .../java/com/replaymod/core/tweaker/ReplayModTweaker.java | 4 +++- .../java/com/replaymod/extras/modcore/ModCoreInstaller.java | 2 +- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/main/java/com/replaymod/core/ReplayModMMLauncher.java b/src/main/java/com/replaymod/core/ReplayModMMLauncher.java index 37dc700d..ceec12b0 100644 --- a/src/main/java/com/replaymod/core/ReplayModMMLauncher.java +++ b/src/main/java/com/replaymod/core/ReplayModMMLauncher.java @@ -53,7 +53,9 @@ public class ReplayModMMLauncher implements Runnable { String mcVer = minecraft.get().getMetadata().getVersion().getFriendlyString(); int result = ModCoreInstaller.initialize(gameDir, mcVer + "_fabric"); - System.out.println("ReplayMod ModCore init result: " + result); + if (result != -2) { // Don't even bother logging the result if there's no ModCore for this version. + System.out.println("ReplayMod ModCore init result: " + result); + } if (ModCoreInstaller.isErrored()) { System.err.println(ModCoreInstaller.getError()); } diff --git a/src/main/java/com/replaymod/core/tweaker/ReplayModTweaker.java b/src/main/java/com/replaymod/core/tweaker/ReplayModTweaker.java index a202fe8e..d08c7bdf 100644 --- a/src/main/java/com/replaymod/core/tweaker/ReplayModTweaker.java +++ b/src/main/java/com/replaymod/core/tweaker/ReplayModTweaker.java @@ -57,7 +57,9 @@ //$$ } //$$ //$$ int result = ModCoreInstaller.initialize(Launch.minecraftHome, mcVer + "_forge"); -//$$ System.out.println("ReplayMod ModCore init result: " + result); +//$$ if (result != -2) { // Don't even bother logging the result if there's no ModCore for this version. +//$$ System.out.println("ReplayMod ModCore init result: " + result); +//$$ } //$$ if (ModCoreInstaller.isErrored()) { //$$ System.err.println(ModCoreInstaller.getError()); //$$ } diff --git a/src/main/java/com/replaymod/extras/modcore/ModCoreInstaller.java b/src/main/java/com/replaymod/extras/modcore/ModCoreInstaller.java index 4daacef6..6fd0c147 100644 --- a/src/main/java/com/replaymod/extras/modcore/ModCoreInstaller.java +++ b/src/main/java/com/replaymod/extras/modcore/ModCoreInstaller.java @@ -131,7 +131,7 @@ public class ModCoreInstaller { } JsonHolder jsonHolder = fetchJSON(VERSION_URL); if (!jsonHolder.has(minecraftVersion)) { - System.out.println("No ModCore target for " + minecraftVersion + ". Aborting install"); + System.out.println("No ModCore target for " + minecraftVersion + ". This in fine, unless you're specifically looking for ModCore."); return -2; } String latestRemote = jsonHolder.optString(minecraftVersion);