From 0561a9f53cda52acef9e77916a2cacb216e610a3 Mon Sep 17 00:00:00 2001 From: altrisi Date: Sat, 19 Sep 2020 15:10:23 +0200 Subject: [PATCH] Don't create an empty directory with no modcore... ...version available for the current MCVersion. --- .../com/replaymod/extras/modcore/ModCoreInstaller.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/main/java/com/replaymod/extras/modcore/ModCoreInstaller.java b/src/main/java/com/replaymod/extras/modcore/ModCoreInstaller.java index 6fd0c147..40615608 100644 --- a/src/main/java/com/replaymod/extras/modcore/ModCoreInstaller.java +++ b/src/main/java/com/replaymod/extras/modcore/ModCoreInstaller.java @@ -122,6 +122,11 @@ public class ModCoreInstaller { public static int initialize(File gameDir, String minecraftVersion) { if (isInitalized()) return -1; + JsonHolder jsonHolder = fetchJSON(VERSION_URL); + if (!jsonHolder.has(minecraftVersion)) { + System.out.println("No ModCore target for " + minecraftVersion + ". This in fine, unless you're specifically looking for ModCore."); + return -2; + } dataDir = new File(gameDir, "modcore"); if (!dataDir.exists()) { if (!dataDir.mkdirs()) { @@ -129,11 +134,6 @@ public class ModCoreInstaller { return 1; } } - JsonHolder jsonHolder = fetchJSON(VERSION_URL); - if (!jsonHolder.has(minecraftVersion)) { - System.out.println("No ModCore target for " + minecraftVersion + ". This in fine, unless you're specifically looking for ModCore."); - return -2; - } String latestRemote = jsonHolder.optString(minecraftVersion); boolean failed = jsonHolder.getKeys().size() == 0 || (jsonHolder.has("success") && !jsonHolder.optBoolean("success"));